MonkeyLoader.GamePacks.Resonite icon indicating copy to clipboard operation
MonkeyLoader.GamePacks.Resonite copied to clipboard

./run_monkeyloader.sh doest have execution permission in release

Open ToasterUwU opened this issue 1 month ago • 5 comments

When installing everything fresh, the run_monkeyloader.sh isnt executable, resulting in Resonite on Steam looking like it starting, but then after less than a second silently failing.

Im not familiar with C# projects and how the copying around works for that file, so i wont make a PR. But basically, the run_monkeyloader.sh has execution permission in the repo, but whatever process packages into the release file removes that execution permission, making it so that Linux users have some silent crash every time they run Resonite with Monkeyloader. People who arent aware of these kind of small things probably wont figure this out themselves and wont be able to fix it.

Let me know if you need more info.

ToasterUwU avatar Nov 25 '25 21:11 ToasterUwU

Also, not sure about this, but it seems the linux side isnt well tested before release. If you need someone to test the new stuff, feel free to ping me or ask for a review on PRs that touch the linux side in any way. Im happy to spend some time to make sure people have their modloader work out of the box.

ToasterUwU avatar Nov 25 '25 21:11 ToasterUwU

The release was made on Windows, and normally everything added to the tar automatically has full read/write/execute permissions set... no idea why it didn't do that for the .sh this time O.o

Do give me a poke on discord as well, then I can add you to the org.

Banane9 avatar Nov 25 '25 23:11 Banane9

Ohh the tar only i assume? i used the zip because .tar.zip is weird and not handled well in some applications. So did my friend probably. It would be better to make it something common like a .tar.gz

ToasterUwU avatar Nov 26 '25 00:11 ToasterUwU

With the soon to be move to public nuget.org packages with the modding policy allowing ref assemblies now could make CI build the releases on linux too to fix the issue 😏 But ye as a temporary fix before that could maybe change the .tar file name to something like "linux" and just remove the linux scripts from the standard zip version..?

l-2-j avatar Nov 26 '25 20:11 l-2-j

We discussed basically exactly that on Discord and seem to agree on that. Mark .tar.gz as Linux, zip and Windows, CI in the future

ToasterUwU avatar Nov 26 '25 20:11 ToasterUwU

Check out the new instructions n such

Banane9 avatar Dec 05 '25 18:12 Banane9

New instructions are definetly clear enough. Thanks!

ToasterUwU avatar Dec 05 '25 21:12 ToasterUwU

Thanks!

Banane9 avatar Dec 06 '25 12:12 Banane9