requestNetwork icon indicating copy to clipboard operation
requestNetwork copied to clipboard

Published 20 hours ago • verified publisher icon RequestNetwork

chore: update @rainbow-me/fee-suggestions

Open alexandre-abrioux opened this issue 2 years ago • 3 comments

Description of the changes

eip1559-fee-suggestions-ethers has been renamed to @rainbow-me/fee-suggestions.

🚨 This is a major version change, it should not be breaking after taking a look at the library code, but to test before merging.

alexandre-abrioux avatar Oct 06 '22 22:10 alexandre-abrioux

Coverage Status

Coverage remained the same at 89.295% when pulling 2878fa8b7ab01f95c5794911a3b8ab0afccc9624 on eip1559-fee-suggestions into cd4f55d9a759fc6b4837ab7f0ba6a037efecfb37 on master.

coveralls avatar Oct 06 '22 23:10 coveralls

We have this covered in tests right?

kevindavee avatar Oct 07 '22 02:10 kevindavee

@kevindavee No, when first introduced ganache didn't support eip1559 yet. Now it does, we should definitely add tests.

alexandre-abrioux avatar Oct 07 '22 09:10 alexandre-abrioux

replaced by https://github.com/RequestNetwork/requestNetwork/pull/1072 (cc @leoslr)

alexandre-abrioux avatar Feb 24 '23 11:02 alexandre-abrioux