reproin icon indicating copy to clipboard operation
reproin copied to clipboard

Explicit "intendedfor" annotation

Open yarikoptic opened this issue 6 years ago • 3 comments

Absence of "IntendedFor" handling is a notable shortcoming. Recent issue within ReproIn about it was https://github.com/ReproNim/reproin/issues/36#issuecomment-540703285 by @dlevitas.

Although it might be possible to deduce it automagically (https://github.com/nipy/heudiconv/issues/148#issue-294034264), and by default in case of a single fmap (or pair of se scans with differing _dir) to assign to all matching bold/dwi; I wonder if in ReproIn context we should better proceed with explicit convention. E.g. annotating both fmap and target scans with some _key-<index> (e.g. _fmap-1) to bind those together. With solutions for https://github.com/nipy/heudiconv/issues/148 it would also be possible to verify that what was intended to be the fmap is compatible with the target scan.

ideas/feedback?

yarikoptic avatar Oct 19 '19 18:10 yarikoptic

sure, if there is an explicit match in named relation

annotating both fmap and target scans with some _key- (e.g. _fmap-1) to bind those together.

sounds reasonable. what happens for each of the different types of fmaps (pepolar, mag/phase, built in -such as pepolar diffusion scans)

satra avatar Oct 23 '19 02:10 satra

I don't see anything pertaining to IntendedFor in the ReproIn code, so I'm assuming specifying a key to link fmap to corresponding func/dwi acquisitions wouldn't work at this point?

Not sure if this could also be lumped in with the heuristic-options

dlevitas avatar Feb 16 '21 20:02 dlevitas

see my initial review within https://github.com/nipy/heudiconv/pull/482 .

yarikoptic avatar Feb 16 '21 20:02 yarikoptic