brainverse icon indicating copy to clipboard operation
brainverse copied to clipboard

ENH: get client ID and client secret from environment variables

Open kaczmarj opened this issue 7 years ago • 1 comments

It would be good to include logic in eapp/app.js to grab clientID and clientSecret from the environment if it exists. If those environment variables do not exist, get this information from the config file. For GitHub clientID and clientSecret, we can use GITHUB_CLIENT_ID and GITHUB_CLIENT_SECRET. This format can be extended for other services like GMAIL_CLIENT_ID and DROPBOX_CLIENT_ID.

kaczmarj avatar Jan 17 '18 22:01 kaczmarj

The logic should grab ClientID and SecretKey environment variable set in Travis and pass it to app as environment variable and write it to the config file while building distributable app.

smpadhy avatar Jan 28 '18 21:01 smpadhy