Benjamin

Results 104 comments of Benjamin

This needs to be prioritized, it makes development a nightmare when I'm trying to pop pages or sheets and it stays up but I'm tapping widgets underneath. The only option...

Duplicate of https://github.com/dart-lang/dart_style/issues/1645

Just to be 100% clear: you're talking about changing `shared int sharedGlobal = 0` into `int sharedGlobal = Shared(0)`, correct?. Sorry I just don't normally refer to keywords as annotations.

@lrhn I was looking at this code sample from the [proposal](https://github.com/dart-lang/language/blob/main/working/333%20-%20shared%20memory%20multithreading/proposal.md). If it's not going to be a keyword, then I'd much rather have it be a class than an...

Yeah, the only thing you could do is check if it's NOT `Success` and return early, then obviously it would be promoted to `Success`. Though, you wouldn't have any protection...

This would certainly be helpful when using switch statements with enum properties as `case` expressions must be `const`s. Obviously there are better ways for this _exact_ use case but this...

@lrhn That makes sense to me, I was originally gonna propose the exact same thing. Though, I'd like a lint that suggests the change from `final` to `const`.

@AlexV525 Do your changes here fix this issue?https://github.com/cfug/dio/blob/679a14410817357e4b4cb8cee75a3f585d675803/plugins/web_adapter/lib/src/adapter.dart#L312-L333

Can we please get an update on this?