Results 85 comments of Renzo Olivares

Merging this since all failures are expected.

Google Test failures look unrelated.

Hi @chinmoy12c, where you still working on this / did you have any questions about any reviews?

@chinmoy12c Looks like some tests are failing, but they seem unrelated. Maybe a sync up to master will fix them.

Hello @KishanBusa8 and thank you for your contribution. Looks like its a much asked for feature! I'm happy to give you some feedback and try to get this merged. For...

@xvrh That's a good point. Currently if `validator` is defined then the `String` from the validator overrides the `InputDecoration.errorText`. If this was an `errorBuilder` instead that would mean that the...

For option 1, it looks like if the `errorText` is null (this can be because no validator is defined or no `InputDecoration.errorText` is defined) there will be no `error` widget...

@justinmc @LongCatIsLooong This is ready for a re-review edit: found a bug staus: not ready for review.

Hello @yegor-pelykh thank you for reporting this issue! I can confirm the prefix icon overlapping issue is fixed in master, but the label overlapping and suffix icon alignment still exist....

@justinmc @chunhtai @LongCatIsLooong This is ready for review. There's an analyzer issue due to a dependency loop that happens when I bring in `HardwareKeyboard.instance` from `services.dart` into my `selection_recognizers.dart`. I...