Renzo Olivares
Renzo Olivares
This is ready for an initial review with a caveat: I'm still addressing an edge case where the `CupertinoTextSelectionControls` selection handles blocks the `TextSelectionGestureDetector` below it. This will happen when...
Tests currently failing due to #120629
Friendly bump, still looking for a review. The failing tests should clear up when https://github.com/flutter/engine/pull/39693 is merged.
> Can you explain again (or link me) why hiding the handles until kDoubleTapTimeout after the double tap wasn't viable? I think this solution is pretty clean, but I want...
Yeah it's a little unfortunate that it isn't under there. I ran into the same issue. Thank you for investigating this!
I think my main motivation for designing it this way was to accomplish the following as a `StatelessWidget`. At a high level this widget will define some mapping of gesture...
> In both cases, can't you just use `ServicesBinding.instance.keyboard.logicalKeysPressed.contains` directly in the handler? i think we still need the states of the keys pressed when the tap down was initiated....
Hi @tgucio sorry for the delay on the review. Thank you for all the work you've done on this so far! After talking with @justinmc I'm not yet sure how...
Hi @tgucio, i'm still thinking about this and have been prototyping some things, but I think we can make this change work. There is no current PR that this approach...
cc @justinmc from triage.