Renzo Olivares
Renzo Olivares
> I can get behind this. I considered making this change multiple times. The reason why I didn't was because I wanted everything in widgets/magnifier.dart to be text-editing agnostic, since...
@tgucio Could you ask @Hixie for a `test-exempt` on discord? Thanks
@domesticmouse Is this ready for review, or should I hold off?
cc @Renzo-Olivares from triage.
I can reproduce this issue on macOS/iOS/Android when running on `master`. Here is a screenshot of it on the Android emulator. The issue with extra padding can be seen clearly...
Hi @Scerbelo12 I'm currently exploring methods to fix the issue described. I don't have a current timeline on the fix but there is a workaround I can point you to...
Hi @Scerbelo12, as of https://github.com/flutter/flutter/pull/147341 you can now have a TextField as a descendant of a draggable widget and still have the draggable win the GestureArena. Are you still interested...
I'm also still unsure about the name. What do you think about `supportedButtonsFilter`? or would that be confusing with `supportedDevices`? Maybe `allowedButtonsFilter`? `buttonsEventFilter` seems a little confusing to me, it...
> `DoubleTapGestureRecognizer` is going to call `super.isPointerAllowed(event)` which triggers the change we are making. By default it accept all, so no changes. But you can do weird things, because `allowedButtonsFilter`...
Thanks for being very patient and making all these changes so quickly @bernaferrari!! It looks awesome! Just had a few more comments.