vertical-overview icon indicating copy to clipboard operation
vertical-overview copied to clipboard

Support for Gnome Shell 45 (make the extension an ESModule)

Open johnnynoone opened this issue 1 year ago • 8 comments

Just a heads-up: apparently Gnome 45 will require extensions to be ESModules.

johnnynoone avatar Sep 05 '23 16:09 johnnynoone

Would be great

systemd11 avatar Sep 10 '23 23:09 systemd11

Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1052110 with some information like a link to a porting guide

coldtobi avatar Sep 24 '23 14:09 coldtobi

Yup, bring it up to Gnome 45 please.

stdevPavelmc avatar Oct 18 '23 14:10 stdevPavelmc

For everyone who is following this issue, my fork of this repository has Gnome Shell 45 support: https://github.com/mtsoltan/vertical-overview

You can clone it into git clone [email protected]:mtsoltan/vertical-overview.git ~/.local/share/gnome-shell/extensions/[email protected] and it should work.

My changes were aimed at getting it to work, rather than being good practices, and therefore, I won't open a PR with them. The extension settings window looks a bit weird, but is completely usable.

However, for anyone looking to use this extension with Gnome Shell 45, it should be your best bet until the official repo is updated.

Edit: If your key-binds for previous and next workspaces are not working, you have to change them from d-conf editor.

Go to org.gnome.desktop.wm.keybindings and try setting move-to-workspace-up and move-to-workspace-down instead of move-to-workspace-left and move-to-workspace-right.

mtsoltan avatar Oct 24 '23 22:10 mtsoltan

@mtsoltan I tried your fork and can confirm that it works on GNOME 45. Thank you!

I think it is fine if you open a PR, because working code is better than nothing. Or just upload your version to extension.gnome.org. this repo looks abandoned anyway.

xuhcc avatar Nov 06 '23 14:11 xuhcc

Yeah, I don't have time to work on this and I'm also no longer using it myself any longer so it is pretty much abandoned. I am willing to hand over give permissions or transfer ownership of the repo if someone is willing to keep it updated.

RensAlthuis avatar Nov 06 '23 14:11 RensAlthuis

@mtsoltan Your port works quite well. The only issue I have is that it seems to crash after some time (possibly after screen lock) with "swipeTracker is not defined". It has the same error for me if I try to turn it off.

suwalski avatar Nov 08 '23 17:11 suwalski

@mtsoltan your port works well for me as well, and I see the same error as @suwalski as well. It can be consistently reproduced by locking the screen and logging back in. Trace:

user@computer:~$ sudo journalctl /usr/bin/gnome-shell | grep 'vertical-overview'
Nov 20 10:57:29 computer gnome-shell[4450]: JS ERROR: Extension [email protected]: ReferenceError: swipeTracker is not defined
                                                   reset@file:///home/user/.local/share/gnome-shell/extensions/[email protected]/gestures.js:73:9
                                                   disable@file:///home/user/.local/share/gnome-shell/extensions/[email protected]/extension.js:52:18

I'm not familiar with ES. What's the scope of the swipeTracker in the gestures.js/reset()? Shouldn't it be initialized within the function?

achirkin avatar Nov 20 '23 10:11 achirkin