Andrew Turner

Results 22 comments of Andrew Turner

@Kircheneer the issue is when the source and target load to-many relationships into an unordered list as is typically done. The problem is when that order varies between source and...

@Kircheneer Have been thinking about this. Not sure if omitting the `sorted_relationships` is the best idea. The challenge comes when sorting the actual list of dictionaries, you need to define...

@Kircheneer what if we did the annotation in the model creation? I think I have a working case on this. ``` @dataclass class SortedRelationship: sort_key: str class MyModel(NautobotModel): ... relationship_field:...

@Kircheneer my main issue with including the annotation into the TypedDict is that every entry in that list will have that same metadata (so it'll be repeated a significant number...

@Kircheneer what are your thoughts on the changes made since last review? Basically, I have it set to where `sort_relationships` will loop throug hthe `top_level` attribute of the target adapter....

@Kircheneer @jdrew82 , this is ready for review now though it's failing unittests for integrations outside of what I've worked on.

Closed in lieu of https://github.com/Renrut5/nautobot-plugin-ssot/tree/custom-relationship-sorting

I noticed the `get_target_url()` also had the same structure as the method causing errors so I added an exception to that method as well. Exception surrounds just the `class_path` assignment...

Note: I've been unable to recreate issue as described, so may need someone else who has had issue or can recreate it to verify fixes.

@jdrew82 I was personally unable to reproduce it.