UnityPlugin-AVProVideo icon indicating copy to clipboard operation
UnityPlugin-AVProVideo copied to clipboard

Use ordinal string comparisons

Open ghost opened this issue 2 years ago • 1 comments

Please DO NOT LINK / ATTACH YOUR PROJECT FILES HERE

Describe the issue We have noticed some string calls (IndexOf, StartsWith, ToLower etc.) in the C# source that do not pass a StringComparison argument and thus use culture-specific comparison, but they should really be using ordinal comparison (StringComparison.Ordinal) instead to avoid issues on devices set to a non-English locale.

ghost avatar Jan 05 '23 20:01 ghost

We'll look into improving this but if a specific comparison is causing you issues please let us know.

MorrisRH avatar Jan 10 '23 11:01 MorrisRH