scs-sdk-plugin
scs-sdk-plugin copied to clipboard
Miscellaneous changes to the code
Generally did QoL improvements, tried to refactor things and make the naming more consistent. Moved the library from .NET Framework to .NET Standard 2.0 as per Microsoft recommendations. Updated Newtonsoft.Json, added a whole lot documentation. Generally fixed almost everything that Rider complained about.
Probably a breaking change? Some properties and methods had spelling errors I fixed and extracted Wheel class from Trailer and Truck into its own class.
Changes looks great, but the framework change did not seems to work for visual studio. Beside that I would like to use this as a starting point for the new client and would make changes on top of that after the tcp switch.
That means I will create a new repository for this which than only contains the C#-plugin. I think that makes the most sense. So in this repository will remain the core plugin, than the c#-plugin repository to use it with c# and another for the demo.
Also the action is a great start per se, but I am not sure if you pushed it to the wrong branch. I think you wanted to push that commit in your dev branch?
What needs here to be done?:
- [ ] merge current dev state to remove conflicts
- [ ] proper change to standard, I needed to make some additional changes to the project file to archieve this (change project node
<Project Sdk="Microsoft.NET.Sdk">
, Remove dependencies, ItemGroups, remove two Import lines). -> Postbuild moving is missing and compile targets after that) However, I do not know if the change of the project node is needed. But without I did not manage to change the framework to standard. - [ ] change target branch to Rencloud:Dev
- [ ] remove action file and commit it to the other branch?
- [ ] another close look at the code afterwards, but currently everything looks fine
Currently it is your master branch of your fork you want to merge, therefore I will hold back with commiting changes as long as you don't say anything else.
Thanks for the work and fixing a lot of my errors. 😅
Also the action is a great start per se, but I am not sure if you pushed it to the wrong branch. I think you wanted to push that commit in your dev branch?
I think this was done far before the TCP migration was made, so it probably can be closed as the receiving code will also be changed.
I think the best idea is to leave only the plugin in this repository, and create separate repository for code samples for each language separately, or all in one repo sorted by either directories or branches.
Just for clarification with plugin did you mean just the c++ part making the server end getting the data from the game/sdk?
I would not like to update to tcp without provide at least one working client library.