RemoteTech icon indicating copy to clipboard operation
RemoteTech copied to clipboard

Adding an antenna module that does not use animations instead swallows all animations

Open kaufman-bryce opened this issue 8 years ago • 1 comments

Consider the following MM patch, which is intended to add a 160km Omni antenna to all command pods:

@PART[*]:HAS[@MODULE[ModuleCommand]]:NEEDS[RemoteTech]:AFTER[RemoteTech]:FOR[SETIctt]
{
    !%MODULE[ModuleRTAntennaPassive]{}
    %MODULE[ModuleRTAntenna] 
    {
        %IsRTActive = true
        %Mode0OmniRange = 0
        %Mode1OmniRange = 160000

        %TRANSMITTER {
            %PacketInterval = 0.3
            %PacketSize = 2
            %PacketResourceCost = 5.0
        }
    }
}

Notice how it is isn't setting DeployFxModules. Expected behavior is that the antenna doesn't use any animations. Actual behavior is that it takes control over ALL ModuleAnimateGeneric on the part; hiding the animation's manual controls and binding them all to the antenna's activation state.

Specific example: If using Ven's Stock Revamp, the Cupola gains two animations; a shutter animation and window glow. With the above patch, the controls for these animations vanish and they both bind to the antenna. (i.e. antenna on = open shutters windows lights on, antenna off, shutters closed lights off)

kaufman-bryce avatar Aug 19 '15 03:08 kaufman-bryce

In addition to re-checking with current RT, this should be checked with stock CommNet for comparison.

YamoriYuki avatar Jan 09 '17 12:01 YamoriYuki