Remora.Discord icon indicating copy to clipboard operation
Remora.Discord copied to clipboard

Published 20 hours ago • verified publisher icon Remora

Re-type IMessageComponentData.cs#Values as a union array of snowflakes or strings

Open carlst99 opened this issue 2 years ago • 4 comments

Following discussion in https://github.com/discord/discord-api-docs/pull/5823, my assumption in #275 appears to be incorrect, and the underlying type of the values field depends on the type of select menu used. This PR resolves that; however, given the current implementation works, I would like to leave this as a draft until the API docs PR is resolved with hopefully a final answer.

carlst99 avatar Jan 06 '23 21:01 carlst99

Looks like a fine way to handle it. Please add variant test data for snowflake-typed value lists as well.

Nihlus avatar Jan 10 '23 16:01 Nihlus

Are there any updates on this PR?

Nihlus avatar Jun 17 '23 14:06 Nihlus

Hiya @Nihlus, no sorry. Discord's response to my docs PR seemed to indicate I hadn't conveyed my request well, and owing to various things at the time I didn't respond.

I could go for round two on the Discord docs, or we could leave things as-is (deserialising to a string) given the indeterminacy of this case, or we could follow Discord's comment that the data type should always match the type of the select menu and proceed with this implementation - happy to follow your call here 🙂.

carlst99 avatar Jan 08 '24 09:01 carlst99