Yape icon indicating copy to clipboard operation
Yape copied to clipboard

Port handling in options.js and storage.js does not allow subdirectory reverse proxy configurations for Pyload

Open slashmach1 opened this issue 2 years ago • 8 comments

because serverIP and port variables are always concated in a set fashion the url handling does not allow for subdirectory configurations for those utilizing a reverse proxy for pyload. By simply omitting port from storage.js and options.js. i was able to make it work since its always https 443. Other than that it works great!

slashmach1 avatar Jul 04 '22 16:07 slashmach1

just to note; had to retool the server validation line likeso const isValidName = /^(?!://)([a-zA-Z0-9]+.)?[a-zA-Z0-9][a-zA-Z0-9-]+.[a-zA-Z]+/[a-zA-Z0-9]{2,6}?$/i.test(value);

slashmach1 avatar Jul 04 '22 17:07 slashmach1

Same problem, my pyload is behind a proxy and has the "Path Prefix" set. So I can't use the parameter fields with my configuration. I tried to modify the extension files as slashmach1 did, but my firefox does not want to install unsigned extensions...

lgrenier avatar Aug 14 '22 08:08 lgrenier

i should mention my work and testing were on the Chrome version of the extension. additional steps may be needed for firefox

slashmach1 avatar Aug 14 '22 11:08 slashmach1

Same here, the plugin configuration tries to login at an invalid URL e.g. https://mydomain.com/pyload:443/api/login.

lnhrdt avatar Aug 25 '22 19:08 lnhrdt

The new version of Yape now supports subdiretory/path on top of the base URL, there is a new input field in the options page as well as an explicit view of the current URL for convenience and clarity.

Preview: image

Feedbacks are welcome !

RemiRigal avatar Sep 08 '22 13:09 RemiRigal

Thanks for the new option, but it does not seem to save the field "PyLoad server's path" when I put it and save, the plugin says "You are logged in " and when I reload the plugin options, the field shows only / and it does not work...

lgrenier avatar Sep 10 '22 20:09 lgrenier

Thank you for the feedback @lgrenier, the issue has been fixed in version v1.1.2.

RemiRigal avatar Sep 11 '22 08:09 RemiRigal

It works ! Thanks

lgrenier avatar Sep 12 '22 19:09 lgrenier