Rémi Delaporte-Mathurin

Hi @shimwell @LiamPattinson So I think there are several things here and maybe we need seperated issues to make it clearer. The `TokamakSource` class has a method called `sample_sources()` which...

Thanks for this. I guess that works but doesn't test the triangularity. Perhaps we can focus on testing `convert_a_alpha_to_R_Z`. An "easy" way to do it is to create an inverse...

It isn't bijective as is but if you constraint a to be positive than each R, Z couple corresponds to one unique (a, alpha) point doesn't it?

Ah maybe. Well even an approximate is better than what we have currently I suppose :-) Thanks!

If I understand the Muir class is going to be replaced by a muir function returning a Normal class.

Ah yes good point. These are the geometrical properties but we also need some more like "ion temperature at the pedestal", "ion density at the separatrix", etc.

Hi @tokamaster Thanks for taking the time to gather the info. and thanks for the ref I think DEMO's minor radius is 3.1m (9.0/3.1 would be way too large 😄...

> @RemDelaporteMathurin If I'm not mistaken 3.1 is the aspect ratio, so minor radius would be 9.0/3.1 = 2.90322580645 m. @tokamaster Yes you're right, my bad, I probably hadn't had...

Ah yes I guess the neutron rate would be in n/s or n/shot. Anyway the calculation is the same isn't it? for SS machines, the input is the fusion power...

I think it will just have to be described in the docstrings. It's still a fusion power in both cases, the unit of time changes that's all.