Reloaded.Memory.SigScan icon indicating copy to clipboard operation
Reloaded.Memory.SigScan copied to clipboard

AddOffset doesn't append

Open JustArion opened this issue 1 year ago • 1 comments

In PatternScanResult.cs#L35 the Offset is added to the return value, but the current value is never updated in the struct.

According to the summary

Appends to the existing offset if the offset is valid.

Instead, a new instance is returned with the added offset but doesn't update the existing struct the method is a part of.

JustArion avatar Jul 13 '24 23:07 JustArion

The quality of life case is that

somePattern = somePattern.AddOffset(offset);

is more tedious than

somePattern.AddOffset(offset);

JustArion avatar Jul 13 '24 23:07 JustArion