Reloaded-II icon indicating copy to clipboard operation
Reloaded-II copied to clipboard

Check Downloaded and Drag & Dropped Mods for Targetted Game and Warn If None

Open TheBestAstroNOT opened this issue 1 week ago • 10 comments

TheBestAstroNOT avatar Dec 10 '25 19:12 TheBestAstroNOT

Only works for drag and dropping right now, working on support for mods installed via the R2 protocol (it isn't going well)

TheBestAstroNOT avatar Dec 10 '25 19:12 TheBestAstroNOT

PR for https://github.com/Reloaded-Project/Reloaded-II/issues/751

TheBestAstroNOT avatar Dec 10 '25 19:12 TheBestAstroNOT

I also made these two mods to test it https://github.com/TheBestAstroNOT/psychic-happiness/releases/tag/1.0.0

TheBestAstroNOT avatar Dec 10 '25 19:12 TheBestAstroNOT

@dreamsyntax are there any changes you would like to see?

TheBestAstroNOT avatar Dec 11 '25 11:12 TheBestAstroNOT

Ok, now I've properly tested this build.

Drag & Drop image

"No" instead of "Cancel" makes more sense, since the mod itself still gets installed, we just don't set the supported app.

Ideally there would be three options "No" -> no edit, but keeps the mod installed "Yes" -> edit screen "Abort/Cancel" -> does not install the mod at all

Since this happens after a download for example though, I think its fine to just change it to "No" and "Yes" to be more clear that the mod will still be installed.

--

Mod Loader Download Button

  • Does not seem to invoke this flow at all

R2 Links (Gamebanana)

  • Invokes flow successfully

dreamsyntax avatar Dec 11 '25 21:12 dreamsyntax

@dreamsyntax Can you test the mod loader's one click download button again, I'd do it myself but I don't know of any mods that I can test with.

TheBestAstroNOT avatar Dec 12 '25 16:12 TheBestAstroNOT

@dreamsyntax Can you test the mod loader's one click download button again, I'd do it myself but I don't know of any mods that I can test with.

I'll try later today.

If you want to test in interim:

If you add any exe renamed as tsonic_win.exe, it will add Sonic Heroes as a gamebanana source. You'll be able to see 64 Mario skin for that game in the download manager, which has the issue.

dreamsyntax avatar Dec 12 '25 16:12 dreamsyntax

@dreamsyntax Can you test the mod loader's one click download button again, I'd do it myself but I don't know of any mods that I can test with.

I'll try later today.

If you want to test in interim:

If you add any exe renamed as tsonic_win.exe, it will add Sonic Heroes as a gamebanana source. You'll be able to see 64 Mario skin for that game in the download manager, which has the issue.

dreamsyntax avatar Dec 12 '25 16:12 dreamsyntax

image Ok it seems to be working

TheBestAstroNOT avatar Dec 12 '25 17:12 TheBestAstroNOT

Tested.

Feature works as expected now.

@Sewer56 on any objections with the code?

I left a comment about the resource, the rest looks fine.

dreamsyntax avatar Dec 12 '25 20:12 dreamsyntax