relisten-ios icon indicating copy to clipboard operation
relisten-ios copied to clipboard

Published 20 hours ago • verified publisher icon RelistenNet

Request: remove screenshotdetector

Open lukeswitz opened this issue 4 years ago • 10 comments

This feature is baked into TestFlight, data collection must be properly handled, retained and able to be provided to the user with a set expiration, etc.

lukeswitz avatar May 14 '20 11:05 lukeswitz

I think this is still a useful thing to do, and it also lets us get rid of Relisten attempting to access the photo library

farktronix avatar Sep 27 '20 17:09 farktronix

Awesome, I'll get that out of there.

lukeswitz avatar Oct 03 '20 23:10 lukeswitz

Reopening. It's fine if you're done with this, but please leave this open so that someone else can handle it.

farktronix avatar Oct 26 '20 16:10 farktronix

I can break it up so no build settings are changed. Do you have CI firing or is the Travis vs. Realm battle waging on?

lukeswitz avatar Oct 27 '20 16:10 lukeswitz

Thanks! I filed this bug on Realm to see if they have any ideas for fixing the Travis issue: https://github.com/realm/realm-cocoa/issues/6889

farktronix avatar Oct 27 '20 16:10 farktronix

I just fixed up all of the build and Travis woes and pushed fixes to master. You should be able to pull out your specific changes for this from #199 into a new PR

farktronix avatar Oct 29 '20 08:10 farktronix

Awesome! Thanks for the trudging and grinding through all that. Travis sure put up a good fight but I'm glad you won.

lukeswitz avatar Oct 29 '20 10:10 lukeswitz

Wait... the .gitignore had Pods/Realm/**/*.a in it????

This project......ohhh this project.

lukeswitz avatar Oct 29 '20 10:10 lukeswitz

This project......ohhh this project.

The realm pod downloads static binaries that are over 50MB, which GitHub warns about if you try to push them, so we chose to ignore them since they can easily be re-downloaded by Cocoapods:

commit 53aa696c932522a5667d7c5e190709fe5d2f2e6a
Author: Alec Gorge <[email protected]>
Date:   Sun Mar 29 11:39:17 2020 -0700

    Ignore massive Realmbinaries

diff --git a/.gitignore b/.gitignore
index d07f8788..9a8fd9ea 100644
--- a/.gitignore
+++ b/.gitignore

We're working on a complex system with lots of moving parts. Bugs are going to happen, and they're generally going to be due to side effects that nobody could have anticipated. Please assume good intent- we're all trying to do our best.

farktronix avatar Oct 30 '20 20:10 farktronix

The surprise came from choosing one of thirty to exclude. In a typical development work environment we either include them or we don't. This project is different and I see + respect that

lukeswitz avatar Oct 30 '20 20:10 lukeswitz