ramstk icon indicating copy to clipboard operation
ramstk copied to clipboard

fix: derating analysis errors

Open weibullguy opened this issue 2 years ago • 2 comments

Does this PR introduce a breaking change?

  • [ ] Yes
  • [X] No

Describe the purpose of this pull request.

To fix IndexErrors and KeyErrors raised during derating analysis.

Describe how this was implemented.

Added error handling to the derating analysis.

Describe any particular area(s) reviewers should focus on.

None

Provide any other pertinent information.

Pull Request Checklist

  • Code Style

    • [X] Code is following code style guidelines.
  • Static Checks

    • [X] Failing static checks are only applicable to code outside the scope of this PR.
  • Tests

    • [X] At least one test for all newly created functions/methods?
  • Chores

    • [X] Issue(s) have been raised for problem areas outside the scope of this PR. These problem areas have been decorated with an ISSUE: # comment.

weibullguy avatar May 29 '23 13:05 weibullguy

Codecov Report

Patch coverage: 90.41% and project coverage change: -0.08 :warning:

Comparison is base (83c3db7) 96.88% compared to head (d57e40e) 96.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1279      +/-   ##
==========================================
- Coverage   96.88%   96.80%   -0.08%     
==========================================
  Files         157      157              
  Lines        5529     5548      +19     
  Branches      491      498       +7     
==========================================
+ Hits         5357     5371      +14     
- Misses        147      150       +3     
- Partials       25       27       +2     
Flag Coverage Δ
3.10 96.80% <90.41%> (-0.08%) :arrow_down:
3.8 96.79% <90.27%> (-0.08%) :arrow_down:
3.9 96.80% <90.27%> (-0.09%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ramstk/utilities.py 96.29% <ø> (ø)
src/ramstk/__main__.py 50.93% <25.00%> (-0.97%) :arrow_down:
src/ramstk/analyses/derating/models/capacitor.py 92.00% <60.00%> (-8.00%) :arrow_down:
src/ramstk/configuration.py 89.83% <92.00%> (ø)
...c/ramstk/analyses/derating/models/semiconductor.py 100.00% <100.00%> (ø)
src/ramstk/analyses/milhdbk217f/models/inductor.py 100.00% <100.00%> (ø)
...dels/dbrecords/programdb_design_electric_record.py 100.00% <100.00%> (ø)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 29 '23 13:05 codecov[bot]

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
5.7% 5.7% Duplication

sonarqubecloud[bot] avatar May 29 '23 14:05 sonarqubecloud[bot]