Ben Hutton

Results 349 comments of Ben Hutton

@ssilverman The verbose example at https://json-schema.org/draft/2019-09/json-schema-core.html#rfc.section.10.4.4 I hadn't considered that you'd collect annotations separate from the verbose output structure. I'd have expected it as part of the verbose output structure...

> @relequestral for your example, I would expect errors for the missing `a` and `b` plus both titles in a _full_ verbose, but excluding the `a`/`b` title would probably be...

@ssilverman I'm reading the rest of your comment, but I was trying to say, "validity" is NOT an annotation. It's a possible property of the node.

Annotations are ONLY ever attached to an instance. If it's not attached to the instance, it's not an annotation (yet). The annotations are telling you something about the instance at...

I'm going to summarise. The spec says... > Schema objects that produce a false assertion result MUST NOT produce any annotation results, whether from their own keywords or from keywords...

This would have complex consequences. For example, what are the annotation results now? How does such a change impact the additionalProperties, patternProperties, and unevaluatedProperties chain? I'm generally against making these...

I don't want to open this can of worms right now, and we have other issues we DO need to solve. My personal preference would be to close this issue,...

I'd have to read up on what was said, but I can't imagine how this would fix any issues, as it wouldn't be in stead of allowing $ref siblings.

Looks like we have come across a similar question before https://stackoverflow.com/questions/53449740/how-can-i-validate-number-of-digits-in-a-number-using-json-schema-ajv/53449981#comment93772686_53449981 Watch out! > JS treat numbers with leading zeros as octal only if they valid octal, if not then...

> 😏 Do we need to add a `$license` keyword to the meta vocab? I'm in favour of a new governance and providence vocabulary, but haven't had the time to...