VMP-fabric icon indicating copy to clipboard operation
VMP-fabric copied to clipboard

Crash upon joining the world with Immersive Portals 1.1.4

Open luckymomohd opened this issue 4 years ago • 7 comments

On Minecraft 1.18.1 VMP crashes with:

  • Fabric 0.12.12
  • Immersive Portals 1.1.4
  • Fabric API 0.44.0
  • VMP 0.2.0 beta 1.5

Crashlog: https://www.toptal.com/developers/hastebin/gehavecoki.yaml

luckymomohd avatar Dec 17 '21 13:12 luckymomohd

Can you paste this error again on pastebin as the link might be broken?

ishland avatar Jan 01 '22 15:01 ishland

Immersive Portals cannot be compatible with VMP. Because VMP assumes that only the chunks near player is visible to player, but with immptl remote chunks can also become visible via portals.

https://github.com/qouteall/ImmersivePortalsMod/issues/1031

qouteall avatar Apr 11 '22 13:04 qouteall

Immersive Portals cannot be compatible with VMP. Because VMP assumes that only the chunks near player is visible to player, but with immptl remote chunks can also become visible via portals.

qouteall/ImmersivePortalsMod#1031

The mixin errored in your issue is only for caching max tracking distance of an entity to avoid doing expensive queries many times a tick. This value does not depend on distance to players.

ishland avatar Apr 11 '22 15:04 ishland

Oh I misunderstood VMP. You are sure that VMP does not have any assumption that only the chunks and entities near player is visible to player, right? If so immptl can be compatible.

qouteall avatar Apr 12 '22 09:04 qouteall

Well there are some optimizations replacing distance checks of the vanilla ones. If you replace these vanilla mechanics then those optimizations will probably get overridden. VMP also reimplements chunk sending near the players. Chunks may get sent twice if you have your own system of sending chunks. If you just do your thing it should work but I can implement lithium-like mixin system so you can disable some of VMP's mixins. Other optimizations don't involve distance checks.

ishland avatar Apr 12 '22 10:04 ishland

Lithium-like mixin disabling system would be good

qouteall avatar Apr 13 '22 15:04 qouteall

Woo. Adding my own observations: the pretty much only sign of VMP being incompatible with immptl is normal portals not working with optimized entity tracking and general ignorable instability i can't narrow down to 1 thing. (Latest Minecraft, mod, Fabric versions as of 17.08.22)

HyperSoop avatar Aug 17 '22 17:08 HyperSoop