C2ME-fabric icon indicating copy to clipboard operation
C2ME-fabric copied to clipboard

Sinytra Connector Crash

Open MrCubicYT opened this issue 1 year ago • 6 comments

Sinytra Connector need NoTickViewDistance set to false and async set to false, just wanted to point that out because maybe something can be done about it.

MrCubicYT avatar Nov 14 '23 21:11 MrCubicYT

Please follow the issue template.

ishland avatar Nov 19 '23 05:11 ishland

Describe the bug If C2ME and Sinytra Connector (Fabric Loader Mod for Forge) are both installed the game doesn't boot unless configs are changed.

To Reproduce Steps to reproduce the behaviour:

  1. Use Forge 47.1.3 (1.20.1)
  2. Have Sinytra Connector (https://www.curseforge.com/minecraft/mc-mods/sinytra-connector) and C2ME installed.
  3. Watch Minecraft crash

Expected behaviour Minecraft boots preferably with "NoTickViewDistance" and "ThreadedWorldGen" config set to true for better performance.

Screenshots None

Runtime info (please complete the following information):

  • OS: Windows
  • Minecraft version: 1.20.1 (Forge 47.1.3 running Sinytra Connector)
  • Mod version: 0.2.0+alpha.11
  • Mod branch: None

Crash reports / logs https://pastebin.com/Bn5VGCq6

Other mods Sinytra Connector

Checklist

  • [x] I am using the official version of the mod.
  • [x] I tried the latest development version but the issue persists.
  • [x] I searched for similar open issues and could not find an existing bug report on this.

Additional context If "NoTickViewDistance" and "ThreadedWorldGen" are set to false manually in C2ME config the game boots. I was hoping this could be fixed somehow to fix a bit more of Forge's abysmal performance. I haven't ensured the actual performance gains are there but it seems to me like chunks load quicker

MrCubicYT avatar Nov 30 '23 15:11 MrCubicYT

Disabling "NoTickViewDistance" does allow the game to boot up, but the game will crash on attempt to load any world, and here is the crash report: https://mclo.gs/HmVLWKB From the error it appears that Forge & Sintyra Connector is perhaps using some different mapping than what is used during the development of C2ME, causing the mixin refmap to point to a nonexistent class name.

Edit: One of my friends (also a mod developer) suggest that this can be caused by a difference between Yarn Mapping and MojMap: the intended method is net.minecraft.server.level.ChunkMap.lambda.scheduleChunkGeneration.27 in Yarn, but in MojMap it resides in another anonymous class, net.minecraft.server.world.ThreadedAnvilChunkStorage.method_17225.

shanoaice avatar Jan 29 '24 11:01 shanoaice

Disabling "NoTickViewDistance" does allow the game to boot up, but the game will crash on attempt to load any world, and here is the crash report: https://mclo.gs/HmVLWKB From the error it appears that Forge & Sintyra Connector is perhaps using some different mapping than what is used during the development of C2ME, causing the mixin refmap to point to a nonexistent class name.

Edit: One of my friends (also a mod developer) suggest that this can be caused by a difference between Yarn Mapping and MojMap: the intended method is net.minecraft.server.level.ChunkMap.lambda.scheduleChunkGeneration.27 in Yarn, but in MojMap it resides in another anonymous class, net.minecraft.server.world.ThreadedAnvilChunkStorage.method_17225.

You have radium, it will conflict with c2me feature threadedWorldGen, disable it can solve your problem but lost c2me benefits

liangmoe avatar Mar 16 '24 06:03 liangmoe

You have radium, it will conflict with c2me feature threadedWorldGen, disable it can solve your problem but lost c2me benefits

Oh I see. Do I have the option to throw away Radium's threadedWorldGen to use C2ME?

shanoaice avatar Mar 19 '24 05:03 shanoaice

Also sent this in the Connector repo.

Getting this crash with:

  • c2me-fabric-mc1.20.1-0.2.0+alpha.11.5
  • Connector-1.0.0-beta.41+1.20.1
  • fabric-api-0.92.0+1.11.5+1.20.1

Config:

  • noTickViewDistance off
  • threadedWorldGen on, without this the mod isn't actually very useful

MichelJonkman avatar Apr 10 '24 18:04 MichelJonkman