Georgy Shelkovy

simplify error message

1

https://github.com/greenplum-db/diskquota/blob/a939bc078f9b041059ecb223504abb816753a3e4/src/diskquota.c#L858-L864 why not here and in other places simply use SPI_result_code_string(ret_code) instead? like ```c ret_code = SPI_execute(sql, false, 0); if (ret_code != SPI_OK_UTILITY) { ereport(ERROR, (errmsg("[diskquota launcher] SPI_execute error, sql:...

cppcheck find bug

1

```sh prefix.c:1273:12: style: Redundant initialization for 'maxoff'. The initialized value is overwritten before it is read. [redundantInitialization] maxoff = entryvec->n - 1; ^ prefix.c:1260:25: note: maxoff is initialized OffsetNumber maxoff...

Unresolvable unqualified warnings

1

How can I resolve these warnings? ```sql WITH s AS ( SELECT "id" FROM public.task AS t LEFT JOIN "pg_catalog"."pg_locks" AS l ON "locktype" OPERATOR(pg_catalog.=) 'userlock' AND "mode" OPERATOR(pg_catalog.=) 'AccessExclusiveLock'...

commit https://github.com/postgres/postgres/commit/024c521117579a6d356050ad3d78fdc95e44eefa replaces MyBackendId by MyProcNumber and ParallelLeaderBackendId by ParallelLeaderProcNumber

according to https://github.com/postgres/postgres/commit/75680c3d805e2323cd437ac567f0677fdfc7b680#diff-8e191e2481b10ecfde671fd489a0fb23f09a4259da9144e9a60292fdc7afeadbL108

cppcheck find bug

2

```sh plpgsql_debugger.c:1119:7: style: Condition 'target' is always true [knownConditionTrueFalse] if( target ) ^ plpgsql_debugger.c:1077:6: note: Assuming that condition '!target' is not redundant if (!target) ^ plpgsql_debugger.c:1119:7: note: Condition 'target' is...

cppcheck find bug

2

```sh dblink_plus/dblink_oracle.c:610:3: portability: Returning an integer in a function with pointer return type is not portable. [CastIntegerToAddressAtReturn] return false; ^ ```

solve ```diff diff --git a/action.yml b/action.yml index 24c1643..331f43e 100644 --- a/action.yml +++ b/action.yml @@ -9,12 +9,21 @@ inputs: upstream: description: 'Upstream repository owner/name. For example, exions/merge-upstream' required: true + email:...

When serializing long slices, increased memory consumption is possible, mine exceeds 3 gigabytes! Steps to reproduce: save this ```go package main import ( "fmt" "os" "github.com/goccy/go-yaml" ) type TOC struct...