ReiNXToolkit icon indicating copy to clipboard operation
ReiNXToolkit copied to clipboard
verified publisher icon Reisyukaku

Compilation failed

Open BenMitnicK opened this issue 7 years ago • 12 comments

Hi, I use devkitpro for windows and I have an error at end compilation and I don't found solution for this

Service Access must be an object! Failed to parse descriptor json! make[1]: *** [/opt/devkitpro/libnx/switch_rules:35: /home/BMK/switch/ReiNXToolkit-master/ReiNXToolkit.npdm] Error 1 make: *** [Makefile:168: build] Error 2

BenMitnicK avatar Oct 07 '18 22:10 BenMitnicK

Uhh try updating your toolchain. I use msys2 pacman to install the dependencies

Reisyukaku avatar Oct 07 '18 23:10 Reisyukaku

everything is up to date and same error ... I tested Tinfoil and NX-Shell and the compilation is ok no error ... I think my installation is correct

linking ReiNXToolkit.elf built ... ReiNXToolkit.nso Service Access must be an object! Failed to parse descriptor json! make[1]: *** [/opt/devkitpro/libnx/switch_rules:35: /home/BMK/switch/ReiNXToolkit-master/ReiNXToolkit.npdm] Error 1 make: *** [Makefile:168: build] Error 2

BenMitnicK avatar Oct 08 '18 08:10 BenMitnicK

same problem on my Centos7

Ts1ng avatar Oct 09 '18 08:10 Ts1ng

it's weird and impossible to find a solution always I have this error please help me I want to contribute for add code on your app

BenMitnicK avatar Oct 09 '18 16:10 BenMitnicK

I know it isn't exactly a "fix" but by removing $(OUTPUT).nsp from line 185 of the make file will allow it to finish compiling successfully, but it looks like it won't create a .nsp file which I'm assuming it's supposed to do now.

Crusatyr avatar Oct 10 '18 02:10 Crusatyr

a temporarily method that can use the orign json file https://raw.githubusercontent.com/Reisyukaku/ReiNXToolkit/117857a301b24f5d9074407299c92de7b1d123a3/ReiNXToolkit.json.And roblabla has a pull request on npdmtool that has not been merged. https://github.com/switchbrew/switch-tools/pull/20

Ts1ng avatar Oct 10 '18 05:10 Ts1ng

A shot in the dark but i may have fixed it .

Reisyukaku avatar Oct 10 '18 08:10 Reisyukaku

@Reisyukaku The PR said to not merge until a new release of switch-tools is published with the changes, this is why these errors are occuring.

I recommend reverting bb0fa to solve this, and if you'd like, I can ask robabla to create a new PR.

ThatNerdyPikachu avatar Oct 10 '18 23:10 ThatNerdyPikachu

Who sends out a PR if shits not ready lol.. i read the majority of it but not that part.

Reisyukaku avatar Oct 13 '18 07:10 Reisyukaku

People who work on big projects where stuff needs tweaking beyond a simple PR->merge. It happens a lot on libnx for example.

shchmue avatar Oct 15 '18 16:10 shchmue

Geez, way to not be an asshole. I opened it early in order to catch some feedback (like https://github.com/switchbrew/nx-hbloader/pull/6) and gauge the impact. I didn't expect someone would just merge it without:

  1. Understanding what it does
  2. Making sure it works
  3. Reading the description

Anyways, I'll reopen the PR when it's ready. In the meantime, you should revert the commit. You can do that by clicking on the "revert" button on https://github.com/Reisyukaku/ReiNXToolkit/pull/3 , or by running git revert f016b238811819569719969361d1c2c7a0ad7b23

roblabla avatar Oct 15 '18 21:10 roblabla

Calm down sweety ;)

  1. I understand its pointless changes just like they always do in libnx
  2. Worked on my machine
  3. I already stated i missed that part.

Reisyukaku avatar Oct 15 '18 21:10 Reisyukaku