Piotrek Koszuliński

Results 90 issues of Piotrek Koszuliński

So far we implemented a support only for synchronous media preview generation. This means that we can preview things like YT and Vimeo, for which we can predict the ``s...

status:discussion
type:feature
package:media-embed
support:2
squad:core

Right now we use 2-4 processes to work with multiple repos. I raised the number to 4-8 and reduced e.g. `mgit update` time from about 30-40% (although, more tests would...

status:discussion
type:enhancement

The discussion started in https://github.com/cksource/mgit2/pull/82#issuecomment-420630223 and continued for a couple next comments. Initially, I assumed that `mgit close` should work like `git merge` on steroids – you call it when...

* Some code snippets are incorrectly rendered on npm: https://www.npmjs.com/package/mgit2 * ToC is missing (take https://github.com/ckeditor/ckeditor5 for instance) * Mention other projects using it?

In package.json we say this is MIT while in every file we point to a non-existing LICENSE.md We should do like here: https://github.com/benderjs/benderjs/blob/master/lib/browsers.js

type:task

Not very clear now: ```js execCommand.execute( execOptions( `git checkout ${ repository.branch }` ) ); ```

type:enhancement

If you use a command, you need to call its methods (`beforeExecute`, `execute` and `afterExecute`) manually.

type:enhancement

That would allow avoiding sth like this: ```js .then( () => { return execCommand.execute( execOptions( `git checkout ${ repository.branch }` ) ); } ) .then( ( response ) => {...

type:enhancement

On hover: Border: Link balloon: Media embed: Misc: * I think it's a too low contrast between icon face and bg.

type:imporovement

Some integration/E2E tests with Strapi would be great. There's not much that can go wrong now, so basic ones would be enough.

type:task