Nishan icon indicating copy to clipboard operation
Nishan copied to clipboard

Add support for transclusion_reference

Open alfredsgenkins opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe. I can not reference the transclusion_reference type block. When I do it, the following error is displayed:

Block type is not of the supported types
Given type: transclusion_reference

Describe the solution you'd like I would like to get support for this block, the @nishan/types already has all typing for it, the @nishan/core seems to be out of date.

Additional context I have the following dependencies specified in my application:

"@nishans/core": "^0.0.35",
"@nishans/types": "^0.0.57",

The example of code, which may cause this issue:

const syncedBlocks = await page.getBlocks((block) => block.type.includes('transclusion'), true);

Please note, the page should include the synced block on it to throw this error.

alfredsgenkins avatar Mar 10 '22 12:03 alfredsgenkins

I have fixed it temporarily, by modifying the node_modules/@nishans/core/node_modules/@nishans/constants/dist/libs/blockTypes.js to include transclusion_reference and transclusion_container.

alfredsgenkins avatar Mar 10 '22 12:03 alfredsgenkins

Hey, thank you for raising the issue. I've been super busy with my academics and work so can't give an exact deadline on when this will be implemented. I'm glad that you managed to figure out the solution.

Devorein avatar Mar 23 '22 03:03 Devorein