ReimarBauer

should flake8 cry on unused variables?

4

Just seen https://github.com/Open-MSS/MSS/blob/stable/mslib/msui/mscolab.py#L1965C57-L1966C1 name, file_ext = fs.path.splitext(file_name) is defined but not used. I am not sure about if our test in the past had seen that. So: yes

Due to the separate development of the flight path and operations, we now have different templates for their defaults. We should change the mscolab to be able to use the...

review refactor mscolab.sockets_manager

1

We have to check if all defined on_event are used (not only in tests) and remove not used.

problem with performance settings reloading

2

My system tells me: ERROR: Problems reloading stored performance settings (: unable to convert a C++ 'QVariantMap' instance to a Python object). Switching to default DEBUG: storing settings for topview...

Currenly only on topview we write the name of the operation or flightrack

I want to check that we process all submitted data and assert when not. It maybe is not a failure but we should investigate the cases. And also for the...

the operation list and its state needs to be updated for users when the active operation is archived or deleted by one user. currently on other clients the operation did...

state of active operation / flighttrack not defined on removing an operation user

1

We should maybe always activate the first flighttrack when a user gets removed from the operation. The data gets cleared from an open TopView. I am not sure if we...

can have a problem in time comparison FAILED tests/_test_mscolab/test_file_manager.py::Test_FileManager::test_modify_user - assert datetime.datetime(2024, 7, 10, 20, 11, 1, 45996, tzinfo=datetime.timezone.utc) == datetime.datetime(2024, 7, 10, 18, 11, 1, 45996, tzinfo=datetime.timezone.utc) ``` assert...

We need in the msui under help a documentation entry about the various views.