Reika_Mods_Issues icon indicating copy to clipboard operation
Reika_Mods_Issues copied to clipboard

[Rotarycraft v33a] Crash when right clicking bevel gears

Open MrDanS-21 opened this issue 1 year ago • 9 comments

It seems that when I try to right click any bevel gear to open it's gui, the game crashes every time.

Crash Report: https://pastebin.com/GuVxnnXZ

MrDanS-21 avatar Aug 27 '23 10:08 MrDanS-21

we can confirm, - after update from RotaryCraft+1.7.10+V32c to RotaryCraft+1.7.10+V33a RCM on bevel gear crahing client side

Description: Rendering screen java.lang.NoClassDefFoundError: Reika/ChromatiCraft/Auxiliary/Interfaces/NBTTile

ptk2003 avatar Aug 28 '23 20:08 ptk2003

can also confirm the crashes. The error with the chromaticraft also appears for me, although I don't have chromaticraft installed

Holorizor avatar Aug 31 '23 21:08 Holorizor

Confirmed in Rotary Skies

AstoriaFloyd avatar Sep 04 '23 02:09 AstoriaFloyd

https://github.com/ReikaKalseki/RotaryCraft/blob/b2288638f7f4703bb4555f72a2b86f72407cc2ae/Registry/MachineRegistry.java#L1002 line needs a sanity check for if NBTTile is defined, since while chromaticraft is not present it of course will not be, thus causing the crash

Vectrobe avatar Sep 09 '23 06:09 Vectrobe

Also can confirm. If we play without Chromaticraft, this issue is consistently reproducible.

smilodon79 avatar Oct 09 '23 15:10 smilodon79

can confirm, im having the same issues, is there any other way to rotate the bevels without rightclicking for now?

Davirus-Hash avatar Oct 25 '23 11:10 Davirus-Hash

I'll also add my comment to keep the issue relevant, since it is highly annoying.

You can force the bevel gears to be in the right orientation by having the input and output shafts already placed and placing bevel gears last, so at least there is a workaround for the issue.

Konrad-Wszelaki avatar Oct 28 '23 09:10 Konrad-Wszelaki

Getting the same issue, however, not 100% reproduceable. Sometimes they behave fine, other times they crash me 10 times in a row. Also noticed they cause crashes less often on our server, compared to singleplayer.

Kerzenmacher avatar Oct 31 '23 15:10 Kerzenmacher

https://github.com/ReikaKalseki/RotaryCraft/blob/b2288638f7f4703bb4555f72a2b86f72407cc2ae/Registry/MachineRegistry.java#L1002 line needs a sanity check for if NBTTile is defined, since while chromaticraft is not present it of course will not be, thus causing the crash

Since I already have a pre-existing mod built for 1.7.10 (practicalities magnet keybind mod), I went ahead and added that exact interface to the mod and re-compiled it which fixes the issues since it provides that interface to the bit of code you mentioned.

Anyone on a 1.7.10 pack that happens to already be using practicalities already feel free to use this fix until Reika adds a check there. the original mod for comparison if you are worried about virus

my re-compiled change with literally just this class added into the Jar

If anyone desperately wants a standalone mod to fix this just @ me on this thread, otherwise I'm not going to bother, just putting this out here in case it helps anyone.

TheUnderTaker11 avatar Dec 06 '23 15:12 TheUnderTaker11