Reika_Mods_Issues
Reika_Mods_Issues copied to clipboard
ReikaKalseki
Multiple Reikas Mods issues, Renderer, Lag & Removal of Disable Alpha Clipping?
Since i'm not getting a reply on discord i guess i gotta submit the issues here.
1: Did you change anything in the renderer for your mod since I'm getting a lot of new issues since the last time I updated.
This is a screenshot of an Actually Additions "Solidified Experience" With your mods: https://i.imgur.com/UapjJwE.jpg Without your mods: https://i.imgur.com/l7i6ge3.jpg
i dont know if this is to do with any changes you've made but i've been seeing a lot more odd things since i updated your mods https://i.imgur.com/NEyjzar.jpg as you can see the pure black shadow and the villager being really really bright there are also black shadows under orbs now https://i.imgur.com/Q6sMwcx.png never seen those before look how bright villagers are https://i.imgur.com/yUv5dm2.jpg it wasnt like this before
this is a clean install with just your mods and actually additions https://i.imgur.com/CdXyUpH.png
also you removed "B:"[DB20D45DD] Disable Alpha Clipping in WorldRenderer"=true" from the configs? how come? I thought it was meant to be a performance boost option
and that ties into my next point too; im getting heavy stuttering with JUST your mods installed, no others and its not present without them.
Happy to help debug in any way just let me know how I can help!
I forgot to mention, I tried with and without the launch option "-DragonAPI_ForceAlphaClip" to see if it made a difference with the rendering issues, It did not.
also I don't know if this means anything or if its just a replacement for some type of renderer or what but i'm using warmroast and your mod is showing up in the categories; no clue what it means but maybe its worth a look https://i.imgur.com/59G4VpX.png
@brandynn try removing ChromatiCraft and see if your issues persist. There was a significant overhaul in DragonAPI that removed the above flag, and replaced it with another solution that means the "performance boost" that flag gives is always enabled now, hence why the flag was removed. However, @OvermindDL1 and I are currently trying to debug performance issues related to ChromatiCraft simply being present in the installed mods.
I don't have chromaticcraft. My Reika mods: ExpandedRedstone 1.7.10 24a ElectriCraft 1.7.10 V24a RotaryCraft 1.7.10 V24C DragonApi 1.7.10 V24c
@brandynn if you could please give me a full list of your hardware specs, that'd be appreciated. CPU, Memory, Graphics Card, etc.
ofcourse, anything for you ;)
GPU: Nvidia GTX 1060 6GB CPU: AMD Ryzen 7 2600 RAM: 16GB Corsair Vengeance 3200Mhz OS: Windows 10 Storage: 4TB HDD & 2TB HDD MOBO: X470 Gaming Pro
How much ram are you allocating to the game? Also, are you using the G1GC garbage collector? Also, playing the game on HDDs means your chunk loading / generation is going to be impeded. Would recommend an SSD for a major boost in whole system performance, including all of your games.
As i said, There are no issues unless i use Reikas mods(which are integral to my pack)- I have 4gb of ram allocated, my pack only uses 2gb and performance doesnt change no matter how much I allocate(the only difference in performance is with reikas mods vs without) either way, this isnt only about performance and more about the rendering issues that are taking place.
I need the list of arguments you're using to run the game @brandynn. While the arguments are not relevant to the rendering, they almost certainly could be related to the performance issues you're seeing.
-Xmx 4gb and no others. I tried with the force alpha clip launch command to but it didn't change anything.
@brandynn try it with these arguments and see if the performance stuttering you're seeing goes away:
-Xms4G -Xmx4G -XX:+UseG1GC -XX:+UnlockExperimentalVMOptions -XX:MaxGCPauseMillis=100 -XX:+DisableExplicitGC -XX:TargetSurvivorRatio=90 -XX:G1NewSizePercent=50 -XX:G1MaxNewSizePercent=80 -XX:G1MixedGCLiveThresholdPercent=35 -XX:+AlwaysPreTouch -XX:+ParallelRefProcEnabled
These are what I use when I'm doing performance testing of Reika's stuff, and right now without ChromatiCraft, on a Ryzen 3700X and a GTX 1070, I'm getting close to 400-500 fps at any given moment.
The rendering issue will be more difficult to diagnose. As for the flag you referred to, as I said, that flag no longer exists, therefore putting it in will do nothing because it doesn't exist.
I can test it, but if it does work I still see that as an issue since I don't want ever player who plays my pack to have to enter launch options, and is it not sort of an issue that you'd need launch options for something that should run well without it anyway?
It is a known thing that the G1GC performs significantly better in minecraft than the default garbage collector of Java 8, which is the CMS.
@ReikaKalseki This also may help with performance debugging, not completely sure but it may help: https://i.imgur.com/pbghDT1.png
It is a known thing that the G1GC performs significantly better in minecraft than the default garbage collector of Java 8, which is the CMS.
i can try it but still i shouldn't have to add launch commands.
Asking Reika to work around the problems of an ancient garbage collector is entirely unreasonable when the fix takes literally 3 seconds of effort on your part, which never has to be repeated unless you delete the installation. Furthermore, the default vanilla launcher installation comes with the G1GC arguments by default.
As of a recent version of the minecraft launcher, the following arguments come with the vanilla launcher profiles:
-Xmx1G -XX:+UnlockExperimentalVMOptions -XX:+UseG1GC -XX:G1NewSizePercent=20 -XX:G1ReservePercent=20 -XX:MaxGCPauseMillis=50 -XX:G1HeapRegionSize=16M
As I said previously, It's not about ME, it's about the players of my pack; they shouldn't have to go and add a launch command to play properly, it should be plug and play.
You're apparently not hearing me. By default the vanilla launcher comes with the arguments I just specified. A player would have to explicitly remove them for them to not be there, or use another launcher. If they're using another launcher, it becomes their responsibility to optimise their performance via the JVM arguments if that launcher does not come with any arguments by default.
It is quite literally one of the most basic options of the JVM, the thing that runs behind Minecraft and other Java applications. There is no way on Earth Reika can change anything to do with that.
@brandynn the big deal here is, you said you're not using those default arguments when you posted. So when I asked you to do the tests with the G1GC to see if the performance issues went away, that's why, because the default Java GC for Java 8 is not the G1GC, but the default arguments provided with minecraft explicitly tell the JVM to use the G1GC.
Then it should be using G1GC by default, i'm on the technic launcher because I like to seperate my instances depending on what i'm working on, but sure, i'll test it just incase the technic launcher doesn't already have it built in(which it should)- and i'll get back to you i guess.
I crashed and it seems to be due to the renderer
java.util.ConcurrentModificationException at java.util.ArrayList$Itr.checkForComodification(Unknown Source) at java.util.ArrayList$Itr.next(Unknown Source) at Reika.DragonAPI.Extras.ThrottleableEffectRenderer.doRenderParticles(ThrottleableEffectRenderer.java:192) at Reika.DragonAPI.Extras.ThrottleableEffectRenderer.func_78874_a(ThrottleableEffectRenderer.java:160) at net.minecraft.client.renderer.EntityRenderer.func_78471_a(EntityRenderer.java:1275) at Reika.DragonAPI.ASM.ASMCalls.onRenderWorld(ASMCalls.java:72) at net.minecraft.client.renderer.EntityRenderer.func_78480_b(EntityRenderer.java:1015) at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1001) at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:898) at net.minecraft.client.main.Main.main(SourceFile:148) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
crash-2020-01-27_02.16.41-client.txt fml-client-latest.log
another rendering issue with your mods installed( doesnt happen without ) black pixels on porkchop only when holding / on floor, not in inventory. https://i.imgur.com/r9wtFcP.jpg
I crashed while playing and the only thing it really links to is again Reika's mods (Never seen this type of crash before and there's nothing note worthy in the logs and I can't upload the log since it's too big) crash-2020-02-15_15.48.51-client.txt
This crash happened straight after that one, this time on world creation: crash-2020-02-15_16.20.21-client.txt
notable part from the log: https://pastebin.com/tUukaDpw
The first crash you've linked is COFH's issue, not Reika's. Something in that light code decided to crap the bed, and is not within Reika's domain.
The second crash regarding the ThrottleableEffectRenderer, Overmind and I have been trying to convince Reika to implement a better solution for that, that would solve not only this issue, but multiple others, but have had limited success so far. That is likely to be an intermittent issue, and will not happen constantly.
The first crash does seem to be linked to DragonAPI's renderer- but I wouldn't know