Rehike icon indicating copy to clipboard operation
Rehike copied to clipboard

New comment model completely destroys comments.

Open aubymori opened this issue 1 year ago • 8 comments

Jesus Christ. The monkeys have fucking done it again. They completely fucked comments. Now, instead of the commentThreadRenderer containing the comment data, like a SANE FUCKING API, they decided it would be a great idea to instead give it a key (commentKey) that refers to an object in a completely separate array (frameworkUpdates.entityBatchUpdate.mutations) which also have this key (entityKey) and have the actual comment content. I seriously did not think they could get any more retarded, but they've done it.

Anyways, here's a full next continuation response containing this FUCKTARDED change:

garbage.json

aubymori avatar Jan 31 '24 00:01 aubymori

FYI, this has already completely fucked V3.

image

aubymori avatar Jan 31 '24 00:01 aubymori

https://github.com/Rehike/Rehike/commit/de6ac9d3187260027d4e30a0061f6c3651882339

I wrote a few classes to make parsing these pieces of shit easier, but it's still tedious and I don't want to work on it.

ephemeralViolette avatar Jan 31 '24 02:01 ephemeralViolette

I think this is mostly fixed now, but I'll keep the issue open in case there's anything else that's important.

YukisCoffee avatar Feb 04 '24 11:02 YukisCoffee

Now the like/dislike button on comments doesn't work, heart button is broken(all comments in my channel has hearts and my comment on other channel has a heart button), replying throws visual errors(though reloading shows my new reply) since about two weeks ago

bluedragon-cairo avatar Apr 04 '24 07:04 bluedragon-cairo

I can't add a comment or add a reply on any video, I also have the same issues as bluedragon.

Xammand avatar Apr 13 '24 16:04 Xammand

Posting the comment shows infinite loading but reloading page shows your new comment as far as I know... I temporarily switched to Vorapis V3 until Rehike fixes comments again so not sure about now though

bluedragon-cairo avatar Apr 15 '24 07:04 bluedragon-cairo

@bluedragon-cairo @Xammand Posting comments and liking/disliking comments work now, but posting replies still don't

syndiate avatar Apr 26 '24 22:04 syndiate

@syndiate Yup that stuff works and replies don't for me. I'm also still having issues where every comment on a video I post have the heart on them even though I never favorited them. Clicking on it doesn't do anything.

Xammand avatar Apr 26 '24 23:04 Xammand

Comments have been back to regular functionality for a while now. This issue will be closed. Any new issues pertaining to comment viewmodel parsing should be opened separately.

kawapure avatar Jun 08 '24 23:06 kawapure