scpcb icon indicating copy to clipboard operation
scpcb copied to clipboard

Reintroduce achievement changes (using vanilla save compatibility system)

Open ChronoQuote opened this issue 1 year ago • 0 comments

This PR acts as an alternative to #200, which also reintroduces the achievement changes but uses a new save compatibility system to resolve the issues they had with saves. In this branch, the issues are instead resolved with the vanilla CompatibleNumber system.

4d337e0 Revert "Reverted achievement changes because they break compatibility with older save files"

d5460fb Revert "Removed leftover bits of the SCP-066 achievement (the addition of this new achievements was reverted in accc9600aed, but these changes were accidentally left in). #251"

These revert commits accc960 and 75eee99.

Summary of reintroduced changes:

  • Add SCP-066 achievement that unlocks when the player gets close enough to 066 for it to perform an action; icon by Jabka666
  • Fix achievement order and update DrawEnding to make "SCPs encountered" value on ending screen more accurate (since it is based on achievement order); now 990 is the only SCP missing from this value because it has no achievement
  • Move AchvConsole to last page of achievements next to AchvKeter so that the only achievements on the last page are ones that are unlocked after beating the game
  • Capitalization and punctuation corrections to achievement strings

Note that some pieces of these changes (like the update to DrawEnding) were mistakenly never reverted in the first place and so were not actually reintroduced by this commit, but everything is still listed above anyway.

Video showcasing some of these changes: https://streamable.com/5ypca8

7a464e2 Fix save compatibility with achievement changes

This commit uses the vanilla CompatibleNumber system to fix the issues the achievement changes had with saves.

Due to the new save file structure, CompatibleNumber had to be updated to 1.3.12. Since 1.3.11 saves are still supported, extra checks for 1.3.11 saves had to be added as well.

For an explanation of the CompatibleNumber system, see #200.

09dee89 Change version number to 1.3.12

VersionNumber had to be changed to 1.3.12 sooner or later, and now that the CompatibleNumber is 1.3.12, I think this is a good time.

VersionNumber is what appears in the app title and in the corner of the main menu.

ChronoQuote avatar Sep 16 '23 06:09 ChronoQuote