scalapack icon indicating copy to clipboard operation
scalapack copied to clipboard

Can I make a PR to implement meson builder support

Open AtilaSaraiva opened this issue 3 years ago • 4 comments

Hello guys,

I know there is the CMake already in place, but I still want to implement support for the meson builder. That way I can wrap this github project as a subproject dependency on my repositories. That way, if the used doenst have it already installed on their machine, it will trigger the compilation. Since it uses ninja, it also may shorten the compilation time considerably.

Thx!

AtilaSaraiva avatar Oct 30 '21 01:10 AtilaSaraiva

I think you should just make a PR ;) All build-systems are orthogonal to each other, so this should be fine.

Note: I am not a maintainer here, so have no say in this.

zerothi avatar Dec 16 '21 22:12 zerothi

The thing is that I intend to make changes in file structure of the repository, so I'll not be able to maintain support for SCons development, but I intend to still use SCons for recipes (although everyone should be using python by now).

AtilaSaraiva avatar Dec 16 '21 22:12 AtilaSaraiva

Hmm, I see. I don't think that would be appropriate... Which kind of changes?

zerothi avatar Dec 17 '21 07:12 zerothi

On the LAPACK side of things, we had a discussion about this and we decided to remove the meson build. See: https://github.com/Reference-LAPACK/lapack/pull/511 It is not my preference to add a meson build to ScaLAPACK for now. We can discuss about the merit. Please read the discussion related to the PR https://github.com/Reference-LAPACK/lapack/pull/511

langou avatar Dec 17 '21 18:12 langou