lapack
lapack copied to clipboard
Set SCALE early for robust triangular solvers
Update robust triangular solver LATRS
and robust banded triangular solver LATBS
.
-
The docs define
SCALE
as an output argument. SetSCALE
before the quick return case to haveSCALE
set (to the expected value 1.0) in all cases. This is how the similar routineTRSYL
handles the corner case already. -
Remove invocations of
LABAD
in complex routines and be consistent with the real counterparts, which do not callLABAD
.
@weslleyspereira Thanks for your review. The remaining data types have been added; the link to the issue has been moved to the commit message.
In view of #96, I did not reintroduce LABAD
.
Thanks for citing issue #96 ! I talked to Jim Demmel and other people, and they recommended removing those calls as well.
Weslley
On Sun, Sep 25, 2022 at 10:22 AM angsch @.***> wrote:
@weslleyspereira https://github.com/weslleyspereira Thanks for your review. The remaining data types have been added; the link to the issue has been moved to the commit message.
In view of #96 https://github.com/Reference-LAPACK/lapack/issues/96, I did not reintroduce LABAD.
— Reply to this email directly, view it on GitHub https://github.com/Reference-LAPACK/lapack/pull/712#issuecomment-1257228134, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD6AT6OUKCKHOMIK22JCWHDWAB33LANCNFSM57FDVRMA . You are receiving this because you were mentioned.Message ID: @.***>
-- Weslley S. Pereira