lapack icon indicating copy to clipboard operation
lapack copied to clipboard

Update Function Arguments in `?gees`, `?geesx`, `?gges`, `?ggesx`, and `?gges3`

Open foxtran opened this issue 1 month ago • 7 comments

Instead of using external keyword for Function Arguments, this PR introduces explicit interfaces for Function Arguments. The code should be more safe now, and source code reflect documented behaviour. Later, it will help a lot to generate proper interfaces for these functions.

BIND(C) is used since code can be called from other than Fortran languages.

Checklist

  • [x] The documentation has been updated: no need to update documentation.
  • [x] Closes #1171

foxtran avatar Nov 30 '25 09:11 foxtran

Hmmm.. I used flang 21.1.6 on MacOS Ventura 13.7.8 to check what wrong in CI, and all tests were passed.

Configure command:

cmake -G "Ninja" -DCMAKE_Fortran_COMPILER=flang -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=ON -DCMAKE_Fortran_FLAGS="-g" ..

testing:

ctest . --parallel 4

Where I can find where LAPACK calls are located?

foxtran avatar Nov 30 '25 21:11 foxtran

Call tree looks valid. I have no idea why test failed.

foxtran avatar Nov 30 '25 22:11 foxtran

@langou, could you please add --output-on-failure flag to ctest command into CI?

foxtran avatar Dec 01 '25 08:12 foxtran

I added one for .github/workflows/cmake.yml (seems like other 'ctest' had it.) Let me know if you want it at other places. Note: I'll need a "maintainer" to approve my PR so as to be able to merge it.

langou avatar Dec 01 '25 09:12 langou

Let me know if you want it at other places.

What is about continuous-integration/appveyor/pr?

foxtran avatar Dec 01 '25 09:12 foxtran

Ok. Found where it is :-)

foxtran avatar Dec 01 '25 10:12 foxtran

No, I definitely has no idea why appveyor fails.

foxtran avatar Dec 01 '25 11:12 foxtran