lapack icon indicating copy to clipboard operation
lapack copied to clipboard

( nor urgent ) lines of code never called in STEDC

Open langou opened this issue 6 months ago • 0 comments

In DSTEDC, it seems that these lines of code are never called and so can safely been removed: https://github.com/Reference-LAPACK/lapack/blob/efbd2fdf4439cdf5e11f9ff3ee9c65dd81164580/SRC/dstedc.f#L439-L444

Lines 439 to 444 are never called since, at lines 306, IF( ICOMPZ.EQ.0 ) THEN we call STERF and GOTO 50 https://github.com/Reference-LAPACK/lapack/blob/efbd2fdf4439cdf5e11f9ff3ee9c65dd81164580/SRC/dstedc.f#L306-L311 and, after 50 CONTINUE, STEDC ends https://github.com/Reference-LAPACK/lapack/blob/efbd2fdf4439cdf5e11f9ff3ee9c65dd81164580/SRC/dstedc.f#L468-L476

It is not possible that ICOMPZ is 0 in lines 439 to 444, so the lines are never executed.

Thanks to @BrianDang03 for pointing this.

langou avatar Jun 30 '25 22:06 langou