git-partial-submodule icon indicating copy to clipboard operation
git-partial-submodule copied to clipboard
verified publisher icon Reedbeta

Fix gitmodules handling for clone command

Open Kinokin opened this issue 3 years ago • 2 comments

  • handle relative submodule url
  • handle special branch '.'

Kinokin avatar Jul 25 '22 07:07 Kinokin

Thanks for the PR! I think the code can likely be simplified a lot using os.path.relpath and such rather than parsing the path yourself. See how I'm doing it for the submodule paths a few lines earlier: https://github.com/Reedbeta/git-partial-submodule/blob/bd8bb4e7ace4a932455ac06a847314679194493c/git-partial-submodule.py#L194

Also, it looks like you used 3-space indents instead of 4 - I'd appreciate if you can clean that up. 🙂

Reedbeta avatar Jul 25 '22 20:07 Reedbeta

Hi Nathan, yes, its a quick hack to get an experiment working. I can't spend any more time on this, sorry

Kinokin avatar Jul 26 '22 03:07 Kinokin