dotnet-maui-check icon indicating copy to clipboard operation
dotnet-maui-check copied to clipboard

Breaks coming for .NET workloads

Open jonathanpeppers opened this issue 4 years ago • 2 comments

I thought I'd just file an issue here, so you'll have an example of what's coming:

https://github.com/dotnet/designs/pull/188/files#diff-8fcaa29d8e6f00b34b3cb1830d93f33e75f04424780a66a3c658c7021048e74fR125

/data/ folder

The workload .nupkg files will now contain:

  • /data/WorkloadManifest.json
  • /data/WorkloadManifest.targets

While while the directory contents on disk will be unchanged.

This was in: https://github.com/xamarin/xamarin-android/pull/5843, https://github.com/xamarin/xamarin-macios/pull/11221

Workload pack rename

Our pack names will become:

  • Microsoft.NET.Sdk.Android.Manifest-6.0.100
  • Microsoft.NET.Sdk.iOS.Manifest-6.0.100

The "version" of the .nupkg will remain our current versions.

The path on disk would be:

dotnet\sdk-manifests\6.0.100\Microsoft.NET.Sdk.Android\
    WorkloadManifest.json
    WorkloadManifest.targets

Drop the .Manifest-6.0.100 from the path on disk.

We will also be able to make the version value in WorkloadManifest.json a string that matches our other versions. Support for this was added in: https://github.com/dotnet/sdk/pull/16746

This is still WIP, we need these bumps to land first:

  • https://github.com/xamarin/xamarin-android/pull/5849
  • https://github.com/xamarin/xamarin-macios/pull/11175

What I got working so far: https://github.com/xamarin/xamarin-android/commit/d8b2da4cc3e6c12074f19af19b2925323f5ebaca

jonathanpeppers avatar Apr 19 '21 17:04 jonathanpeppers

@Redth FYI only the first part, the move to the /data/ folder will be in .NET 6 Preview 4 (it's actually already in).

The second part renaming things will be in a future preview (probably 5?).

jonathanpeppers avatar Apr 22 '21 19:04 jonathanpeppers

The /data/ part is now implemented.

Renaming will just require a change to the maui-check manifest file I think, to use the new manifest id.

Redth avatar Apr 29 '21 18:04 Redth