redocly-cli icon indicating copy to clipboard operation
redocly-cli copied to clipboard

chore: replace node-fetch with native fetch

Open DmitryAnansky opened this issue 1 year ago • 3 comments

What/Why/How?

Checking another approach to get rid off punycode message.

Reference

Testing

Screenshots (optional)

Check yourself

  • [ ] Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • [ ] All new/updated code is covered with tests
  • [ ] New package installed? - Tested in different environments (browser/node)

Security

  • [x] Security impact of change has been considered
  • [x] Code follows company security practices and guidelines

DmitryAnansky avatar Oct 11 '24 16:10 DmitryAnansky

⚠️ No Changeset found

Latest commit: b1764cd99d78b0e305acb56f6e91ecd5720883e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 11 '24 16:10 changeset-bot[bot]

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 979.2 ± 14.9 959.0 1010.0 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 994.9 ± 36.3 964.2 1091.6 1.02 ± 0.04

github-actions[bot] avatar Oct 11 '24 16:10 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟡 Statements 78.62% 5045/6417
🟡 Branches 67.23% 2060/3064
🟡 Functions 73.13% 833/1139
🟡 Lines 78.91% 4759/6031
Show new covered files 🐣
St.:grey_question:
File Statements Branches Functions Lines
🟢 core/src/env.d.ts 100% 100% 100% 100%
Show files with reduced coverage 🔻
St.:grey_question:
File Statements Branches Functions Lines
🟡 core/src/utils.ts 78.7% 67.03% 76.47% 79.47%
🔴
... / registry-api.ts
50% (-1.35% 🔻)
33.33% 50%
48.57% (-1.43% 🔻)
🟢
... / fetch-with-timeout.ts
92.31%
62.5% (-37.5% 🔻)
50% 92.31%
🟡
... / push.ts
73.37% 70% 54.55% 75.78%

Test suite run success

833 tests passing in 120 suites.

Report generated by 🧪jest coverage report action from b1764cd99d78b0e305acb56f6e91ecd5720883e0

github-actions[bot] avatar Oct 11 '24 16:10 github-actions[bot]