redoc icon indicating copy to clipboard operation
redoc copied to clipboard

Make redoc RTL support

Open raha1923 opened this issue 5 years ago • 4 comments

This PR is related to this( #1002 ) issue and we think it's ready to merge. The functionality required for the RTL support project implemented. There are some problems, of course, so please let us know about them if you found any of them.

Notice: This PR is not contained localization.

raha1923 avatar Oct 08 '19 13:10 raha1923

Thanks for your work. This is a big PR and have to be reviewed carefully.

I will review it as soon as I have time.

We plan Redoc 2.0 release soon so I will have a few days dedicated to reviewing/merging PRs soon.

RomanHotsiy avatar Oct 16 '19 13:10 RomanHotsiy

So good to hear that. we have done our bests to make it useful and backward compatible.

raha1923 avatar Oct 16 '19 13:10 raha1923

I think it's better to implement RTL and LTR support using CSS features created for that purpose. At this moment these features have Editor's Draft status, but they're implemented in most browsers except IE and 1st gen Edge. Seems like logical keyword does not working in Chrome yet, however it isn't necessary to use.

Check MDN for docs about CSS Logical Properties and Values.

flaksp avatar Dec 13 '19 14:12 flaksp

Hey @raha1923.

Are you still interested in this PR? We have it on our roadmap but we don't have enough time right now.

We're going to release 2.0.0 soon so we'll ping you here and if you are interested in this PR we would kindly ask you to rebase.

Sorry for delay.

RomanHotsiy avatar Mar 28 '22 14:03 RomanHotsiy

Thanks so much for opening this pull request. This isn't a feature we're comfortable adopting at this time, and the pull request is also outdated. I'm therefore closing this, but with thanks for using Redoc and sharing your ideas with us!

lornajane avatar Aug 22 '23 09:08 lornajane