redistimeseries-go icon indicating copy to clipboard operation
redistimeseries-go copied to clipboard

Sum in DuplicatePolicyType

Open Shriram-RP opened this issue 3 years ago • 3 comments

I notice that Sum is present as a DuplicatePolicy type in both official documentation and also in some other clients but why is it missing from redistimeseries-go. Is there a way in which we could do this? Or can we add it here?

Shriram-RP avatar Nov 10 '21 11:11 Shriram-RP

Hi there @Shriram-RP , you're absolutely right, for some reason we've missed it. Do you want to open a PR addressing it? Or should we fix it? The const's are placed in https://github.com/RedisTimeSeries/redistimeseries-go/blob/master/common.go#L61

filipecosta90 avatar Nov 10 '21 11:11 filipecosta90

For some reason I am receiving 403 errir when I am trying to push my code changes.

fatal: unable to access 'https://github.com/RedisTimeSeries/redistimeseries-go.git/': The requested URL returned error: 403

Can you fix it?

Shriram-RP avatar Nov 11 '21 06:11 Shriram-RP

Hi @Shriram-RP Can you commit to a fork, and make a Pull request? Then we can review! This might help

chayim avatar Nov 14 '21 07:11 chayim