redisjson-py icon indicating copy to clipboard operation
redisjson-py copied to clipboard

Add path defaults to all commands

Open daTokenizer opened this issue 6 years ago • 2 comments

for ease of use, the default path would always be the root as defined by Path.rootPath()

daTokenizer avatar Oct 23 '18 09:10 daTokenizer

Coverage Status

Coverage remained the same at 100.0% when pulling 7bf76ea5cba88d2fa9082d0dc901f18a998fe0ce on daTokenizer:master into 5e1ea9a4802f784c16c4cf9a066a3c7b3d31b5aa on RedisLabs:master.

coveralls avatar Oct 23 '18 09:10 coveralls

Defaulting to the root path makes sense imo.

This PR, however, also bundles a new command, jsonmgetl, which accepts a list of key names instead of the existing variadic format of jsonmget. This I like less :) As a compromise, I can live with how redis-py's mget works, by accepting both a list and arguments. However, I'd like to see that come in as a separate change to the code, tests and documentation.

itamarhaber avatar Jan 06 '19 16:01 itamarhaber