RedisJSON icon indicating copy to clipboard operation
RedisJSON copied to clipboard

RediSearch now supports arch64, so `sbin/get-redisearch` should as well.

Open 5HT2 opened this issue 4 years ago • 5 comments

See: https://github.com/RediSearch/RediSearch

Currently sbin/get-redisearch does not support arch64 on Linux. It would be great if this could be fixed.

5HT2 avatar Nov 07 '21 01:11 5HT2

Hi! Currently we're not yet publishing arm based artifacts, though we will in the future. I've self-assigned for the future case.

chayim avatar Nov 08 '21 09:11 chayim

Thank you :)

There are currently unofficial modified images such as https://github.com/bbilly1/rejson which accomplish the same via manual compilation, as the official Docker image in this repo doesn't work due to the get-redisearch script

5HT2 avatar Nov 08 '21 23:11 5HT2

I'm checking in from time to time on the ARM64 progress, I know it's in the pipeline and I'm looking forward to an official release.

So this is just a FYI: I've successfully rebuild ReJSON for v2.0.6. No compilation errors, no runtime errors I can see, everything seems to be working just fine.

Dockerfile and build script used are here just in case but there were no modifications necessary: https://github.com/bbilly1/rejson

bbilly1 avatar Dec 20 '21 16:12 bbilly1

Oh, it's good to know that no modifications are required now. It would be good if the maintainers popped in to check on this issue, as I'm unsure if it was an intentional change or if things just fixed themselves downstream.

5HT2 avatar Dec 21 '21 03:12 5HT2

Very much intentional, #550 #551 and more. Before these commits, there were some runtime dependency problems that required some unfortunate workarounds, but that's all fixed now. There were also some upstream fixes needed, but that's also merged: https://github.com/RedisLabsModules/readies/pull/69.

I very much appreciate the progress happening!

bbilly1 avatar Dec 21 '21 03:12 bbilly1