redisbloom-go
redisbloom-go copied to clipboard
Support dial options
add options for dial when connecting to Redis (allowing to control options such as read/write/connect timeout, keep alive and more)
Codecov Report
Merging #27 (5675347) into master (3da966a) will increase coverage by
0.04%. The diff coverage is83.33%.
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 86.84% 86.89% +0.04%
==========================================
Files 2 2
Lines 266 267 +1
==========================================
+ Hits 231 232 +1
Misses 20 20
Partials 15 15
| Impacted Files | Coverage Δ | |
|---|---|---|
| client.go | 89.42% <50.00%> (ø) |
|
| pool.go | 72.50% <100.00%> (+0.70%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 3da966a...5675347. Read the comment docs.
@damikem LGTM but we need to add a new method instead of changing the old one so that we're retrocompatible. Can we add a NewClientWithOptions ? Glad to help if required :)