VectorSimilarity icon indicating copy to clipboard operation
VectorSimilarity copied to clipboard

[MOD-9264] Elaborate preprocessors API

Open meiravgri opened this issue 9 months ago • 1 comments

Changes

preprocessStorageInPlace(blob, processed_bytes_count) Implementation:

This pull request introduces the preprocessStorageInPlace capability to the preprocessor interface, enabling in-place modification of storage blobs.

  • Added preprocessStorageInPlace to the PreprocessorInterface in preprocessors.h.
  • Implemented preprocessStorageInPlace for MultiPreprocessorsContainer and CosinePreprocessor classes.
  • Integrated preprocessStorageInPlace(blob) in the VecSimIndexAbstract class for in-place blob preprocessing.

Factory Updates:

Additionally, it refactors parameter creation for preprocessors in the index factory by splitting it into a separate function, to allow CreatePreprocessorsContainer to be called independently of CreateIndexComponents.

  • Introduced CreatePreprocessorsContainerParams in components_factory.cpp (new file)

meiravgri avatar Apr 03 '25 11:04 meiravgri

Codecov Report

Attention: Patch coverage is 33.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 96.31%. Comparing base (b996755) to head (9e937f2). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...rc/VecSim/spaces/computer/preprocessor_container.h 0.00% 6 Missing :warning:
src/VecSim/spaces/computer/preprocessors.h 0.00% 4 Missing :warning:
.../VecSim/spaces/computer/preprocessor_container.cpp 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
- Coverage   97.19%   96.31%   -0.88%     
==========================================
  Files         106      107       +1     
  Lines        5702     5759      +57     
==========================================
+ Hits         5542     5547       +5     
- Misses        160      212      +52     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 03 '25 12:04 codecov[bot]

Successfully created backport PR for 8.0:

  • #645

github-actions[bot] avatar Apr 07 '25 13:04 github-actions[bot]