VectorSimilarity icon indicating copy to clipboard operation
VectorSimilarity copied to clipboard

Deprecate initial capacity

Open alonre24 opened this issue 1 year ago • 1 comments

Describe the changes in the pull request

Deprecate this parameter, always initialize an index with 0 capacity. The goal here is to have the resize (which relies on the index capacity) aligned for the vector blocks and other data structures. As a consequence, in a tiered index, we can make sure that we resize blocks only when we are locked exclusively.

Mark if applicable

  • [ ] This PR introduces API changes
  • [ ] This PR introduces serialization changes

alonre24 avatar Sep 17 '24 13:09 alonre24

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.93%. Comparing base (5011de8) to head (3514bb2). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
- Coverage   97.02%   96.93%   -0.09%     
==========================================
  Files         100      100              
  Lines        5307     5287      -20     
==========================================
- Hits         5149     5125      -24     
- Misses        158      162       +4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 18 '24 22:09 codecov[bot]