VectorSimilarity icon indicating copy to clipboard operation
VectorSimilarity copied to clipboard

[MOD-6775] introduce fp16 type!

Open meiravgri opened this issue 1 year ago • 1 comments

change bfloat and fp16 to struct typedef to avoid ambiguty between them

Describe the changes in the pull request

A clear and concise description of what the PR is solving.

Which issues this PR fixes

  1. #...
  2. MOD...

Main objects this PR modified

  1. ...
  2. ...

Mark if applicable

  • [ ] This PR introduces API changes
  • [ ] This PR introduces serialization changes

meiravgri avatar May 07 '24 14:05 meiravgri

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.18%. Comparing base (d2e1d4f) to head (29c1773).

Additional details and impacted files
@@                     Coverage Diff                      @@
##           meiravg_feature_bfloat16     #462      +/-   ##
============================================================
+ Coverage                     97.10%   97.18%   +0.07%     
============================================================
  Files                            85       85              
  Lines                          4633     4684      +51     
============================================================
+ Hits                           4499     4552      +53     
+ Misses                          134      132       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 07 '24 14:05 codecov[bot]

change bfloat and fp16 to struct typedef to avoid ambiguty between them

Describe the changes in the pull request

A clear and concise description of what the PR is solving.

Which issues this PR fixes

  1. #...
  2. MOD...

Main objects this PR modified

  1. ...
  2. ...

Mark if applicable

  • [ ] This PR introduces API changes
  • [ ] This PR introduces serialization changes

Let's try to better use the PR template... in this particular case we do introduce (small) API change

alonre24 avatar May 09 '24 16:05 alonre24