RediSearch icon indicating copy to clipboard operation
RediSearch copied to clipboard

Unify repeated Lettuce/Spring clients and remove JRediSearch

Open sazzad16 opened this issue 2 years ago • 4 comments

sazzad16 avatar Apr 25 '22 06:04 sazzad16

Codecov Report

Merging #2729 (eae8319) into master (900dabe) will increase coverage by 0.02%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2729      +/-   ##
==========================================
+ Coverage   81.87%   81.89%   +0.02%     
==========================================
  Files         180      180              
  Lines       29664    29664              
==========================================
+ Hits        24286    24292       +6     
+ Misses       5378     5372       -6     
Impacted Files Coverage Δ
src/fork_gc.c 57.12% <0.00%> (+0.80%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Apr 25 '22 07:04 codecov[bot]

@sazzad16 I think since JRediSearch is deprecated we should remove it

gkorland avatar Apr 26 '22 14:04 gkorland

@gkorland redis-om-spring is using JRediSearch at this moment. Perhaps we can wait for some time before removing it.

sazzad16 avatar Apr 26 '22 14:04 sazzad16

@sazzad16 we should remove it so new users won't start new projects with JRediSearch

gkorland avatar Apr 27 '22 09:04 gkorland