RSCoordinator icon indicating copy to clipboard operation
RSCoordinator copied to clipboard

[2.2] Update coordination strategy of FlatSearchCommandHandler

Open Skoucail opened this issue 3 years ago • 4 comments

Add MRCluster_MastersOnly to the coordination strategy of the FlatSearchCommandHandler This fixes #326

Skoucail avatar Dec 02 '21 14:12 Skoucail

@rafie Can you help me? I have no clue why that 1 single test fails on the build server because of my PR

Skoucail avatar Dec 02 '21 15:12 Skoucail

Hello @Skoucail, this is a flaky test, just needs a re-run. However, please note we no longer accept PRs on the RSCoordinator repo (as RSCoordinator is now integrated into the RediSearch repo). Instead, please open a PR on RediSearch/master, and modify files under the coord directory. Thanks!

rafie avatar Dec 02 '21 21:12 rafie

@rafie Oh okee, didnt know this repo is depricated now. I did a test with the RediSearch 2.2 branch. Same issue. So i recreated the pull request over in RediSearch: https://github.com/RediSearch/RediSearch/pull/2404

Skoucail avatar Dec 02 '21 22:12 Skoucail

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Sep 22 '22 14:09 CLAassistant