dnd5e not all critial damage options work

[spirritus]

Currently betterRolls5e offers 5 types to calculate crit damage. However not all options work.

1. No Extra Damage (works as expected)
2. Roll Critical Damage Dice (works as expected)
3. Roll Base Damage, Max Crit (works as expected)
4. Max Base & Max Critical Damage -> this only maximized the crit dice, the base roll is not modified
5. Max Base Damage, Roll Critical Damage -> this seems to just roll all the dice, as option 2 would.

Foundry 0..8.9 dnd5e 1.5.3 betterrolls 1.6.14

[CarlosFdez]

Did you double check to make sure that the max crit contains the bonus damage from the max base. That's how it's supposed to work.

The reason is that when damage is applied, you can choose to apply non-crit or crit damage. If the base was maximized all the time, then you can't differentiate the two. So the diff of the max base is added to the crit.

If you open up the card you should see its like that, unless its truely bugged.

[spirritus]

Ok, for option 5) that seems to work, however at first glance it is not immediatley evident that the difference to the max base roll is added to the crit roll. Maybe incorporate some feedback into the card.

For option 4) the base roll is never maximized. There is no additional damage applied to the crit roll to make up the difference.